Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to quick-score for fuzzy search (leftover) #2370

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

tobiabocchi
Copy link
Contributor

I think you might have left this behind when you were working on this PR I noticed it because the fuzzy finding functionality using !task was not working anymore. I also noticed in that PR you changed the score target from .4 to .35, I was not sure wether it was necessary here so I did not do it for now. One last thing I am not sure that the require statement is in the right place but if it isn't I can move it where you prefer.
This is my first time contributing to Min I hope I did everything according to your requirements.

@PalmerAL
Copy link
Collaborator

Thanks! You're right, I forgot to change this.

This file seems to be sorted with external dependencies followed by other files in the project, so I guess the import should go after fs. It doesn't matter too much though.

The score threshold is arbitrary; in that PR, I tested some different values with my own history database and 0.35 seemed to produce the best results. If you try changing it here, do the results seem better with one value or another?

@tobiabocchi
Copy link
Contributor Author

I moved the dependency up, I tried both .35 and .4 and it did not seem to make any difference to me, maybe you can try it out and see which one works best for you or give me some tasknames and search patterns to try out

@PalmerAL
Copy link
Collaborator

I agree, it seems fine as is, let's go with it.

Thanks for fixing this!

@PalmerAL PalmerAL merged commit ec5bf35 into minbrowser:master Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants