Trim quotes when returning selector comments (#3940)

Let's not return the description quoted to the user. Related: #3723
mindersec · Jul 19, 2024 · 8041df2 · 8041df2
1 parent 5ad938d
commit 8041df2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/db/profile_selector_scan.go b/internal/db/profile_selector_scan.go
@@ -63,7 +63,9 @@ func (s *ProfileSelector) Scan(value interface{}) error {
 	selector = strings.TrimSuffix(selector, "\"")
 	s.Selector = selector
 
-	s.Comment = parts[4]
+	comment := strings.TrimPrefix(parts[4], "\"")
+	comment = strings.TrimSuffix(comment, "\"")
+	s.Comment = comment
 
 	return nil
 }
diff --git a/internal/db/profiles_test.go b/internal/db/profiles_test.go
@@ -246,7 +246,7 @@ func TestProfileListWithSelectors(t *testing.T) {
 
 	noSelectors := createRandomProfile(t, randomEntities.proj.ID, []string{})
 	oneSelectorProfile := createRandomProfile(t, randomEntities.proj.ID, []string{})
-	oneSel := createRepoSelector(t, oneSelectorProfile.ID, "one_selector1", "one_comment1")
+	oneSel := createRepoSelector(t, oneSelectorProfile.ID, "one_selector1", "multi word comment")
 
 	multiSelectorProfile := createRandomProfile(t, randomEntities.proj.ID, []string{})
 	mulitSel1 := createRepoSelector(t, multiSelectorProfile.ID, "multi_selector1", "multi_comment1")