Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim quotes when returning selector comments #3940

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 19, 2024

Summary

Let's not return the description quoted to the user.

Related: #3723

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manual + there's a unit test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Let's not return the description quoted to the user.

Related: mindersec#3723
@jhrozek jhrozek requested a review from a team as a code owner July 19, 2024 13:31
@coveralls
Copy link

Coverage Status

coverage: 54.191%. remained the same
when pulling 87630ea on jhrozek:selector_db_trim_quotes
into 5ad938d on stacklok:main.

@jhrozek jhrozek merged commit 8041df2 into mindersec:main Jul 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants