Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add severity to rule in ListEvaluationHistory RPC. #4012

Closed
blkt opened this issue Jul 26, 2024 · 0 comments · Fixed by #4014
Closed

Add severity to rule in ListEvaluationHistory RPC. #4012

blkt opened this issue Jul 26, 2024 · 0 comments · Fixed by #4014
Assignees
@blkt

Comments

@blkt
Copy link
Contributor

blkt commented Jul 26, 2024

We track the severity of a rule at the rule type level, and we used to return it to the client via /api/v1/results API.
Add it to /api/v1/history under the rule entry.
@blkt blkt self-assigned this Jul 26, 2024
blkt added a commit that referenced this issue Jul 26, 2024
@blkt
Add severity to rule in ListEvaluationHistory RPC.
7f4cf0a 
Fixes #4012
blkt added a commit that referenced this issue Jul 26, 2024
@blkt
Add severity to rule in ListEvaluationHistory RPC.
b2eee6d 
We track the severity of a rule at the rule type level, and we return
it to the client via `/api/v1/results` API. This change addss it to
`/api/v1/history` as well under the rule entry.

Fixes #4012
@blkt blkt mentioned this issue Jul 26, 2024
Merged
10 tasks
blkt added a commit that referenced this issue Jul 26, 2024
@blkt
Add severity to rule in ListEvaluationHistory RPC.
3c2bfbb 
We track the severity of a rule at the rule type level, and we return
it to the client via `/api/v1/results` API. This change addss it to
`/api/v1/history` as well under the rule entry.

Fixes #4012
blkt added a commit that referenced this issue Jul 26, 2024
@blkt
Add severity to rule in ListEvaluationHistory RPC.
2ca92d7 
We track the severity of a rule at the rule type level, and we return
it to the client via `/api/v1/results` API. This change addss it to
`/api/v1/history` as well under the rule entry.

Fixes #4012
@dmjb dmjb closed this as completed in daf5748 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add severity to rule in ListEvaluationHistory RPC. mindersec/minder
1 participant
@blkt