Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add severity to rule in ListEvaluationHistory RPC. #4014

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add severity to rule in ListEvaluationHistory RPC. #4014

merged 1 commit into from
Jul 29, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 26, 2024

Summary

We track the severity of a rule at the rule type level, and we return it to the client via /api/v1/results API. This change adds it to /api/v1/history as well under the rule entry.

Fixes #4012

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 26, 2024
@blkt blkt requested a review from a team as a code owner July 26, 2024 10:32
@coveralls
Copy link

coveralls commented Jul 26, 2024 •
edited
Loading

Coverage Status

coverage: 54.494% (-0.003%) from 54.497%
when pulling 2ca92d7 on issue-4012
into 95535e5 on main.

@blkt
Add severity to rule in ListEvaluationHistory RPC.
2ca92d7 
We track the severity of a rule at the rule type level, and we return
it to the client via `/api/v1/results` API. This change addss it to
`/api/v1/history` as well under the rule entry.

Fixes #4012
@dmjb dmjb merged commit daf5748 into main Jul 29, 2024
22 checks passed
@dmjb dmjb deleted the issue-4012 branch July 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmjb dmjb dmjb approved these changes

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add severity to rule in ListEvaluationHistory RPC.
3 participants
@blkt @coveralls @dmjb