Remove domain model (part 1 CLI) #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of two PRs to remove the domain model before we launch As discussed on slack, this PR strips out client side cmds for all CRUD type operations in medic around orgs, roles, users , projects. I also removed the old key generation code which we are not using at present and have no immediate need to use. Following this will be a PR to remove / disable the equivalent APIs Signed-off-by: Luke Hinds <luke@stacklok.com>
JAORMX
reviewed
Oct 7, 2023
| {"Organization ID", newUser.OrganizationId}, | ||
| {"Organization Name", newUser.OrganizatioName}, | ||
| {"Project ID", newUser.ProjectId}, | ||
| {"Project Name", newUser.ProjectName}, |
There was a problem hiding this comment.
Do we want to remove the project information? Folks will not be able to set it but it would be handy to get folks used to this information, for when we have a full SaaS
There was a problem hiding this comment.
I am not of to strong an opinion, I figured people might raise questions 'what can I do with a project', but I guess that is a good opportunity to tell them are plans for a domain model. I will include them again.
Signed-off-by: Luke Hinds <luke@stacklok.com>
jhrozek
approved these changes
Oct 8, 2023
| } else if object.Object == "project" { | ||
| project.Project_createCmd.Run(cmd, args) | ||
| } else { | ||
| fmt.Fprintf(os.Stderr, "Error: unknown object type %s\n", object.Object) |
There was a problem hiding this comment.
what is apply good for now? Do we anticipate adding support e.g. for profile apply?
There was a problem hiding this comment.
Happy to cover later, I have tracked your comment for now.
JAORMX
approved these changes
Oct 8, 2023
|
@lukehinds feel free to merge this |
This was referenced Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of two PRs to remove the domain model before we launch
As discussed on slack, this PR strips out client side cmds for all CRUD type operations in medic around orgs, roles, users , projects.
I also removed the old key generation code which we are not using at present and have no immediate need to use.
Following this will be a PR to remove / disable the equivalent APIs
Closes: #1140