Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain model (part 1 CLI) #1137

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Remove domain model (part 1 CLI) #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ddadf9
Remove domain model (part 1 CLI)
lukehinds Oct 7, 2023
80d5fc3
Reinstate project name
lukehinds Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cmd/cli/app/apply/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ import (
"gopkg.in/yaml.v3"

"github.com/stacklok/mediator/cmd/cli/app"
"github.com/stacklok/mediator/cmd/cli/app/org"
"github.com/stacklok/mediator/cmd/cli/app/project"
"github.com/stacklok/mediator/cmd/cli/app/role"
"github.com/stacklok/mediator/internal/util"
)

Expand Down Expand Up @@ -105,17 +102,6 @@ var ApplyCmd = &cobra.Command{
viper.Set(k, v)
}
}

if object.Object == "org" {
org.Org_createCmd.Run(cmd, args)
} else if object.Object == "role" {
role.Role_createCmd.Run(cmd, args)
} else if object.Object == "project" {
project.Project_createCmd.Run(cmd, args)
} else {
fmt.Fprintf(os.Stderr, "Error: unknown object type %s\n", object.Object)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is apply good for now? Do we anticipate adding support e.g. for profile apply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to cover later, I have tracked your comment for now.

os.Exit(1)
}
}
},
}
Expand Down
2 changes: 0 additions & 2 deletions cmd/cli/app/auth/auth_login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ will be saved to $XDG_CONFIG_HOME/mediator/credentials.json`,

func renderNewUser(cmd *cobra.Command, newUser *pb.CreateUserResponse) {
rows := []table.Row{
{"Organization ID", newUser.OrganizationId},
{"Organization Name", newUser.OrganizatioName},
{"Project ID", newUser.ProjectId},
{"Project Name", newUser.ProjectName},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the project information? Folks will not be able to set it but it would be handy to get folks used to this information, for when we have a full SaaS

Copy link
Contributor Author

@lukehinds lukehinds Oct 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not of to strong an opinion, I figured people might raise questions 'what can I do with a project', but I guess that is a good opportunity to tell them are plans for a domain model. I will include them again.

}
Expand Down
38 changes: 0 additions & 38 deletions cmd/cli/app/keys/keys.go
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions cmd/cli/app/keys/keys_generate.go
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions cmd/cli/app/org/org.go
View file
Open in desktop

This file was deleted.

87 changes: 0 additions & 87 deletions cmd/cli/app/org/org_create.go
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions cmd/cli/app/org/org_delete.go
View file
Open in desktop

This file was deleted.

Loading