Use provider ID instead of name when sending events #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
commented
Apr 15, 2024
| if inf.ProviderID == uuid.Nil { | ||
| provider, err = e.providerStore.GetByName(ctx, inf.ProjectID, inf.Provider) | ||
| } else { | ||
| if inf.ProviderID != uuid.Nil { |
There was a problem hiding this comment.
Swapped this condition because it is now expected that the Provider ID path will the more commonly used one
dmjb
commented
Apr 15, 2024
| @@ -0,0 +1,81 @@ | |||
| // Copyright 2024 Stacklok, Inc | |||
There was a problem hiding this comment.
Previously part of the helpers package
dmjb
commented
Apr 15, 2024
| @@ -0,0 +1,47 @@ | |||
| // Copyright 2024 Stacklok, Inc | |||
There was a problem hiding this comment.
Previously part of the helpers package
dmjb
commented
Apr 15, 2024
| @@ -0,0 +1,91 @@ | |||
| // Copyright 2024 Stacklok, Inc | |||
There was a problem hiding this comment.
Previously part of the helpers package. Moved under eea, because only the eea code uses these functions.
My previous PR was part of yesterday evening's deploy to prod, so this PR is safe to merge. |
dmjb
force-pushed
the
eiw-provider-id
branch
2 times, most recently
from
e75757b
to
bf92ab0
Compare
rdimitrov
approved these changes
Apr 19, 2024
Relates to #3071 This PR changes any code which creates an EntityInfoWrapper to use Provider ID instead of name. The name is still left as a field in the event for backwards compatibility purposes, and the consumer can still use the name to create the provider instance. However, the name is no longer populated. Some other refactoring was carried out, specifically moving code from the helper package to more appropriate packages.
JAORMX
approved these changes
Apr 19, 2024
|
Did some local verification |
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3071
This PR changes any code which creates an EntityInfoWrapper to use Provider ID instead of name. The name is still left as a field in the event for backwards compatibility purposes, and the consumer can still use the name to create the provider instance. However, the name is no longer populated.
Some other refactoring was carried out, specifically moving code from the helper package to more appropriate packages.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: