Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repo deletion to move db/provider logic behind interface #3200

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Apr 29, 2024

Relates to #2845

Change the interface of the repo service so that it takes care of DB queries and provider instantiation. This moves various details about repo cleanup out of the controlplane.

As part of this, change the provider cleanup process to delete webhooks directly instead of deleting repos. This avoided a circular dependency, and more closely aligns with the idea that webhook management is a provider-specific detail.

Tested locally.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner April 29, 2024 13:46
@dmjb dmjb marked this pull request as draft April 29, 2024 13:51
Relates to #2845

Change the interface of the repo service so that it takes care of DB
queries and provider instantiation. This moves various details about
repo cleanup out of the controlplane.

As part of this, change the provider cleanup process to delete webhooks
directly instead of deleting repos. This avoided a circular dependency,
and more closely aligns with the idea that webhook management is a
provider-specific detail.
@coveralls
Copy link

coveralls commented Apr 29, 2024

Coverage Status

coverage: 50.589% (+0.07%) from 50.517%
when pulling a559df5 on delete-repo-refactor
into e74fc00 on main.

@dmjb dmjb marked this pull request as ready for review April 29, 2024 13:55
@dmjb dmjb merged commit 8047768 into main Apr 30, 2024
20 checks passed
@dmjb dmjb deleted the delete-repo-refactor branch April 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants