Skip to content

Commit

Permalink
Fix webhook secret file names (#3201)
Browse files Browse the repository at this point in the history
Here's what happened:
 - I submitted PR #3177
 - Ria submitted feedback inline, I accepted it. The suggestions were
   merged into the remote branch.
 - the patch had conflicts with main
 - I resolved the conflicts locally and force-pushed to the remote branch. My
   local branch didn't have Ria's suggestions and the force-push removed
   them

This patch brings back Ria's suggestions so I included her as a
co-author.

Sorry!

Co-authored-by: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
  • Loading branch information
jhrozek and eleftherias authored Apr 29, 2024
1 parent 0f68185 commit e74fc00
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deployment/helm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ spec:
- name: "MINDER_FLAGS_GO_FEATURE_FILE_PATH"
value: "/flags/flags-config.yaml"
- name: "MINDER_WEBHOOK_CONFIG_WEBHOOK_SECRET_FILE"
value: "/secrets/app/repo_webhook_secret"
value: "/secrets/app/github_repo_webhook_secret"
- name: "MINDER_WEBHOOK_CONFIG_PREVIOUS_WEBHOOK_SECRET_FILE"
value: "/secrets/app/repo_fallback_webhook_secret"
value: "/secrets/app/github_repo_fallback_webhook_secret"
{{- if .Values.deploymentSettings.extraEnv }}
{{- toYaml .Values.deploymentSettings.extraEnv | nindent 10 }}
{{- end }}
Expand Down

0 comments on commit e74fc00

Please sign in to comment.