Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook secret file names #3201

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 29, 2024

Summary

Here's what happened:

  • I submitted PR Use webhook secrets from files #3177
  • Ria submitted feedback inline, I accepted it. The suggestions were
    merged into the remote branch.
  • the patch had conflicts with main
  • I resolved the conflicts locally and force-pushed to the remote branch. My
    local branch didn't have Ria's suggestions and the force-push removed
    them

This patch brings back Ria's suggestions so I included her as a
co-author.

Sorry!

Co-authored-by: Eleftheria Stein-Kousathana eleftheria@stacklok.com

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Just visually.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Here's what happened:
 - I submitted PR mindersec#3177
 - Ria submitted feedback inline, I accepted it. The suggestions were
   merged into the remote branch.
 - the patch had conflicts with main
 - I resolved the conflicts locally and force-pushed to the remote branch. My
   local branch didn't have Ria's suggestions and the force-push removed
   them

This patch brings back Ria's suggestions so I included her as a
co-author.

Sorry!

Co-authored-by: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
@jhrozek jhrozek requested a review from a team as a code owner April 29, 2024 14:30
@JAORMX
Copy link
Contributor

JAORMX commented Apr 29, 2024

oops!

@coveralls
Copy link

Coverage Status

coverage: 50.523%. remained the same
when pulling e94c7f4 on jhrozek:use_wh_secret_from_file
into 0f68185 on stacklok:main.

@jhrozek jhrozek merged commit e74fc00 into mindersec:main Apr 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants