Use webhook secrets from files #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted as draft because we need to merge https://github.com/stacklok/infra/pull/1189 first |
eleftherias
reviewed
Apr 25, 2024
|
@eleftherias thank you for catching the bad names! |
eleftherias
previously approved these changes
Apr 25, 2024
|
Are we good to merge this? |
In general yes, I only didn't merge because I'm intermittently available today and I didn't want to force someone else to pick up the breakage in case this doesn't work. |
Instead of relying on the config to set them. Relates to: stacklok/infra#954
jhrozek
force-pushed
the
use_wh_secret_from_file
branch
from
e7bea2c
to
2bf4fdd
Compare
|
@eleftherias @JAORMX could you please approve once again? I just resolved a conflict, no other changes |
eleftherias
approved these changes
Apr 29, 2024
jhrozek
added a commit
to jhrozek/minder
that referenced
this pull request
Apr 29, 2024
Here's what happened: - I submitted PR mindersec#3177 - Ria submitted feedback inline, I accepted it. The suggestions were merged into the remote branch. - the patch had conflicts with main - I resolved the conflicts locally and force-pushed to the remote branch. My local branch didn't have Ria's suggestions and the force-push removed them This patch brings back Ria's suggestions so I included her as a co-author. Sorry! Co-authored-by: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
10 tasks
jhrozek
added a commit
that referenced
this pull request
Apr 29, 2024
Here's what happened: - I submitted PR #3177 - Ria submitted feedback inline, I accepted it. The suggestions were merged into the remote branch. - the patch had conflicts with main - I resolved the conflicts locally and force-pushed to the remote branch. My local branch didn't have Ria's suggestions and the force-push removed them This patch brings back Ria's suggestions so I included her as a co-author. Sorry! Co-authored-by: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of relying on the config to set them.
Relates to: https://github.com/stacklok/infra/issues/954
Change Type
Mark the type of change your PR introduces:
Testing
I just verified that the env names are correct by running:
Review Checklist: