Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete docs/docs/how-to/using-minder-with-ghas.md #3204

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

meganbruce
Copy link
Contributor

@meganbruce meganbruce commented Apr 29, 2024

This content is already in the Tutorials section for Minder SaaS, and I think that's the best place for it. I'm proposing that we delete this file in the Policy and Profile Management section, in favor of having it in Tutorials (so that we don't have the same content in two different places in the Minder docs).

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

This content is already in the Tutorials section for Minder SaaS, and I think that's the best place for it. I'm proposing that we delete this file in the Policy and Profile Management section, in favor of having it in Tutorials (so that we don't have the same content in two different places in the Minder docs).
@meganbruce meganbruce marked this pull request as ready for review April 29, 2024 21:46
@meganbruce meganbruce requested a review from a team as a code owner April 29, 2024 21:46
@coveralls
Copy link

Coverage Status

coverage: 50.528% (+0.01%) from 50.517%
when pulling 430e0ed on meganbruce-patch-1
into e74fc00 on main.

@jhrozek
Copy link
Contributor

jhrozek commented Apr 30, 2024

going to modify the PR opening comment to make the PR validator happy.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlay was merged already and has the information that this document had.

@jhrozek jhrozek merged commit 35efde0 into main Apr 30, 2024
19 of 20 checks passed
@jhrozek jhrozek deleted the meganbruce-patch-1 branch April 30, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants