Simplify crypto config structure #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
fix-crypto-env-var-names
branch
3 times, most recently
from
3048e59
to
feb1eea
Compare
Relates to #3315 My first attempt at a config structure was a bad fit for the envionment variable substitution which we used when deploying minder in k8s. Simplify the crypto config in the following ways: 1) Only one fallback key/algo can be specified instead of a list. This is based under the assumption that we only need a single fallback before migrating to a new key. 2) The keystore config has been changed from a `map[string]any` to a concrete type. If we need more types of config in future, we can add additional concrete types and when filling in the config, only one type needs to be filled in.
dmjb
force-pushed
the
fix-crypto-env-var-names
branch
from
feb1eea
to
25fe404
Compare
dmjb
commented
May 22, 2024
| @@ -152,7 +152,7 @@ spec: | |||
| - name: flags | |||
| configMap: | |||
| name: minder-flags | |||
| optional: true # We expect the outside environment to create this ConfigMap | |||
| optional: true # We expect the outside environment to create this ConfigMap | |||
There was a problem hiding this comment.
Undo accidental space inserted in my previous PR
eleftherias
requested changes
May 22, 2024
eleftherias
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3315
My first attempt at a config structure was a bad fit for the envionment variable substitution which we used when deploying minder in k8s. Simplify the crypto config in the following ways:
is based under the assumption that we only need a single fallback
before migrating to a new key.
map[string]anyto aconcrete type. If we need more types of config in future, we can add
additional concrete types and when filling in the config, only one
type needs to be filled in.
Changes tested locally.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: