Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify crypto config structure #3404

Merged
merged 3 commits into from
May 22, 2024
Merged

Simplify crypto config structure #3404

merged 3 commits into from
May 22, 2024

Commits on May 22, 2024

  1. Simplify crypto config structure

    Relates to #3315
    
    My first attempt at a config structure was a bad fit for the envionment
    variable substitution which we used when deploying minder in k8s.
    Simplify the crypto config in the following ways:
    
    1) Only one fallback key/algo can be specified instead of a list. This
       is based under the assumption that we only need a single fallback
       before migrating to a new key.
    2) The keystore config has been changed from a `map[string]any` to a
       concrete type. If we need more types of config in future, we can add
       additional concrete types and when filling in the config, only one
       type needs to be filled in.
    dmjb committed May 22, 2024
    Configuration menu
    Copy the full SHA
    25fe404 View commit details
    Browse the repository at this point in the history
  2. remove env var for filename

    dmjb committed May 22, 2024
    Configuration menu
    Copy the full SHA
    40d4470 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    869e20c View commit details
    Browse the repository at this point in the history