Branch Protection: Error out if an empty branch is given #3433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This surfaces the case where an empty branch is given to explicit branch
protection calls to GitHub. This is needed as GitHub does not properly
handle this case, and errors end up being slightly unpredictable (things
like segfaults).
Properly defaulting to non-empty branch names is handled in another PR.
Related-to: #3430
Change Type
Mark the type of change your PR introduces:
Testing
Review Checklist: