Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Protection: Error out if an empty branch is given #3433

Merged
merged 1 commit into from
May 27, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 27, 2024

Summary

This surfaces the case where an empty branch is given to explicit branch
protection calls to GitHub. This is needed as GitHub does not properly
handle this case, and errors end up being slightly unpredictable (things
like segfaults).

Properly defaulting to non-empty branch names is handled in another PR.

Related-to: #3430

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This surfaces the case where an empty branch is given to explicit branch
protection calls to GitHub. This is needed as GitHub does not properly
handle this case, and errors end up being slightly unpredictable (things
like segfaults).

Properly defaulting to non-empty branch names is handled in another PR.

Related-to: #3430

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner May 27, 2024 10:30
@JAORMX JAORMX merged commit 7d2b11e into main May 27, 2024
21 checks passed
@JAORMX JAORMX deleted the error-empty-branch branch May 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants