Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Protection: Error out if an empty branch is given #3433

Merged
merged 1 commit into from
May 27, 2024
Merged

Branch Protection: Error out if an empty branch is given #3433

merged 1 commit into from
May 27, 2024

Commits on May 27, 2024

  1. Branch Protection: Error out if an empty branch is given 

    This surfaces the case where an empty branch is given to explicit branch
protection calls to GitHub. This is needed as GitHub does not properly
handle this case, and errors end up being slightly unpredictable (things
like segfaults).

Properly defaulting to non-empty branch names is handled in another PR.

Related-to: #3430

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
    @JAORMX
    JAORMX committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cadd5ee View commit details
    Browse the repository at this point in the history