Validate provider config when creating the OAuth provider or the GitHub App provider. #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new error ErrProviderInvalidConfig that is returned if the ValidateConfig method of the provider Manager fails. This allows the handlers to catch this error and display its details. Fixes: mindersec#3510
Adds the call to clients.ParseV1AppConfig to the code that creates GH apps and returns the providers.ErrProviderInvalidConfig if the parsing fails. Catches the providers.ErrProviderInvalidConfig in the handler code to display a user-friendly message. Fixes: mindersec#3510
jhrozek
changed the title
rdimitrov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a special error code as well as means to catch it in the provider
handlers on provider creation so that we disallow creating providers with bad
config.
Fixes #3510
Change Type
Mark the type of change your PR introduces:
Testing
unit tests + manual
Review Checklist: