Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate provider config when creating the OAuth provider or the GitHub App provider. #3535

Merged
merged 2 commits into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. Handle validation errors for OAuth providers

    Adds a new error ErrProviderInvalidConfig that is returned if the
    ValidateConfig method of the provider Manager fails. This allows the
    handlers to catch this error and display its details.
    
    Fixes: mindersec#3510
    jhrozek committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f4c9112 View commit details
    Browse the repository at this point in the history
  2. Validate GitHub App provider configuration on create

    Adds the call to clients.ParseV1AppConfig to the code that creates GH
    apps and returns the providers.ErrProviderInvalidConfig if the parsing
    fails.
    
    Catches the providers.ErrProviderInvalidConfig in the handler code to
    display a user-friendly message.
    
    Fixes: mindersec#3510
    jhrozek committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0f2635b View commit details
    Browse the repository at this point in the history