Check OpenID audience when validating token. #3541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't currently validate the audience claim in the JWT. The OpenID basic client implementation spec says:
https://openid.net/specs/openid-connect-basic-1_0.html#IDTokenValidation
As part of this, introduce a unique
minder
audience in the development setup. Note that this includes development setup changes to add this audience to both theopenid
scope as well as a newminder-audience
scope. This means that existing clients will receive theminder
scopes as part of theopenid
claim; this will allow existing clients to work with new server, assuming the keycloak configuration for the server is updated.For users running a stand-alone Minder installation, they will need to update their Keycloak configuration similar to the example for development.
Change Type
Mark the type of change your PR introduces:
Testing
Manual testing and updated unit tests.
Review Checklist: