Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace several internal protobufs with Go structs #3878

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 12, 2024

A number of internal-only types are defined as protobufs. These are used solely inside the engine code. Remove them and replace them with plain Go structs.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

A number of internal-only types are defined as protobufs. These are used
solely inside the engine code. Remove them and replace them with plain
Go structs.
@dmjb dmjb requested a review from a team as a code owner July 12, 2024 13:48
@coveralls
Copy link

coveralls commented Jul 12, 2024

Coverage Status

coverage: 53.026% (-0.02%) from 53.048%
when pulling f293fcb on decrease-internal-pbs
into 41e4833 on main.

@dmjb dmjb merged commit 40cbccd into main Jul 12, 2024
21 checks passed
@dmjb dmjb deleted the decrease-internal-pbs branch July 12, 2024 15:10
JAORMX added a commit that referenced this pull request Jul 15, 2024
This reverts commit 40cbccd.

This PR breaks the smoke tests. Explicitly the homoglyph and vulncheck
tests.
dmjb pushed a commit that referenced this pull request Jul 15, 2024
…3890)

This reverts commit 40cbccd.

This PR breaks the smoke tests. Explicitly the homoglyph and vulncheck
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants