Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace several internal protobufs with Go structs (#3878)" #3890

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jul 15, 2024

Summary

This reverts commit 40cbccd.

This PR breaks the smoke tests. Explicitly the homoglyph and vulncheck
tests.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This reverts commit 40cbccd.

This PR breaks the smoke tests. Explicitly the homoglyph and vulncheck
tests.
@JAORMX JAORMX requested a review from a team as a code owner July 15, 2024 08:12
@coveralls
Copy link

Coverage Status

coverage: 52.773% (+0.03%) from 52.747%
when pulling 9175b5c on revert-3878
into f1fba17 on main.

@dmjb dmjb merged commit ff8964a into main Jul 15, 2024
22 checks passed
@dmjb dmjb deleted the revert-3878 branch July 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants