Remove use of entity_profile_rules table
#3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
commented
Jul 16, 2024
| @@ -268,7 +268,7 @@ func (p *profileService) UpdateProfile( | |||
| minderv1.Entity_ENTITY_TASK_RUN: profile.GetTaskRun(), | |||
| minderv1.Entity_ENTITY_BUILD: profile.GetBuild(), | |||
| } { | |||
| if err = updateProfileRulesForEntity(ctx, ent, &updatedProfile, qtx, entRules, rules); err != nil { | |||
There was a problem hiding this comment.
Note that this code already keeps rule_instances updated, so we still have all this information in that table. We are simply getting rid of the duplicated storage of that information in entity_profile_rules
dmjb
force-pushed
the
remove-entity-profile-rules-step-i
branch
from
ae38c11
to
3013244
Compare
PR #3903 replaced the one part of minder which queried the data in the `entity_profile_rules` table. This PR removes the code which adds and removes entries to this table. A future PR will drop the table outright.
dmjb
force-pushed
the
remove-entity-profile-rules-step-i
branch
from
520cb4f
to
79083d3
Compare
dmjb
changed the title
entity_profile_rules tableentity_profile_rules table
blkt
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3903 replaced the one part of minder which queried the data in the
entity_profile_rulestable. This PR removes the code which adds and removes entries to this table. A future PR will drop the table outright.Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: