Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename comment to description in profile's selector message #3919

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 17, 2024

Summary

Description plays better with the FE.

Related: #3722

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

N/A

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner July 17, 2024 13:00
dmjb
dmjb previously approved these changes Jul 17, 2024
@rdimitrov
Copy link
Member

There are quite a few failing checks, are we sure there isn't something to fix?

Description plays better with the FE.

Related: mindersec#3722
@jhrozek
Copy link
Contributor Author

jhrozek commented Jul 17, 2024

There are quite a few failing checks, are we sure there isn't something to fix?

Yes, I apologize. There were some utility functions that were using the old field. But I still think it's OK to rename the field in a backwards-compatible manner because we never implemented the handlers that would let you create selectors.

@coveralls
Copy link

coveralls commented Jul 17, 2024

Coverage Status

coverage: 54.389% (-0.004%) from 54.393%
when pulling 8f7a635 on jhrozek:rename_sel_comment
into 8a27510 on stacklok:main.

@jhrozek jhrozek merged commit 079001e into mindersec:main Jul 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants