Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity id in ListEvaluationHistory RPC. #3933

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 18, 2024

Summary

The id returned as id of the entity is the wrong one and must be fixed. This will probably be followed up by another pull request addressing the need to return the evaluation id.

Fixes #3932

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 18, 2024
@blkt blkt requested a review from a team as a code owner July 18, 2024 16:38
@blkt blkt added the bug Something isn't working label Jul 18, 2024
@blkt blkt force-pushed the fix/rpc-evaluation-history-wrong-entity-id branch from 960861f to c6aa6eb Compare July 18, 2024 16:57
@coveralls
Copy link

coveralls commented Jul 18, 2024

Coverage Status

coverage: 53.96% (+0.005%) from 53.955%
when pulling 0c15bd8 on fix/rpc-evaluation-history-wrong-entity-id
into 079001e on main.

The id returned as id of the entity is the wrong one and must be
fixed. This will probably be followed up by another pull request
addressing the need to return the evaluation id.

Fixes #3932
@blkt blkt force-pushed the fix/rpc-evaluation-history-wrong-entity-id branch from c6aa6eb to 0c15bd8 Compare July 18, 2024 17:10
@blkt blkt merged commit 35f1fc5 into main Jul 19, 2024
21 checks passed
@blkt blkt deleted the fix/rpc-evaluation-history-wrong-entity-id branch July 19, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix entity id in ListEvaluationHistory RPC.
4 participants