Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to evaluation log entries conversion. #3941

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 19, 2024

Summary

This adds minimal test coverage to evaluation history log entries conversion in order to prevent issues like the one solved by commit 5ad938d.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 19, 2024
@blkt blkt requested a review from a team as a code owner July 19, 2024 13:51
This adds minimal test coverage to evaluation history log entries
conversion in order to prevent issues like the one solved by commit
5ad938d.
@blkt blkt force-pushed the test/evaluation-history-log-db-conversion branch from 7a2f9db to 579b16b Compare July 19, 2024 13:53
@coveralls
Copy link

coveralls commented Jul 19, 2024

Coverage Status

coverage: 54.398% (+0.2%) from 54.183%
when pulling 579b16b on test/evaluation-history-log-db-conversion
into 8041df2 on main.

@blkt blkt merged commit dccc11a into main Jul 19, 2024
21 checks passed
@blkt blkt deleted the test/evaluation-history-log-db-conversion branch July 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants