Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selectors available in mindev #3943

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 19, 2024

Summary

Let's make our life easier when developing profiles by making selectors
available in mindev

Fixes: #3726

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

AUTH_TOKEN=youdliketoknowwouldntyou go run cmd/dev/main.go ruletype test --profile /Users/jakub/devel/playground/ghas-selectors.yaml --rule-type /Users/jakub/devel/minder-rules-and-profiles/rule-types/github/secret_scanning.yaml --entity /Users/jakub/devel/playground/repository.yaml --log-level=debug
Profile valid according to the JSON schema!
{"level":"info","eval_status":"skipped","action":"remediate","Timestamp":1721397355551920000,"message":"action is off, skipping"}
{"level":"info","eval_status":"skipped","action":"alert","Timestamp":1721397355551935000,"message":"action is off, skipping"}
Error: error evaluating rule type: evaluation skipped: entity not selected by selectors
Message: Error on execute
Details: error evaluating rule type: evaluation skipped: entity not selected by selectors
exit status 1

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner July 19, 2024 13:59
@coveralls
Copy link

coveralls commented Jul 19, 2024

Coverage Status

coverage: 54.183%. remained the same
when pulling bccd382 on jhrozek:selectors_mindev
into 8041df2 on stacklok:main.

Let's make our life easier when developing profiles by making selectors
available in mindev

Fixes: mindersec#3726
@jhrozek jhrozek merged commit 4d522f1 into mindersec:main Jul 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for selectors into mindev
3 participants