Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function and its tests. #3951

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove unused function and its tests. #3951

merged 1 commit into from
Jul 22, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 22, 2024

In a previous PR, I removed all usages of a function except for one located in a test. I moved the function into the tests as a private function in response. I have since realized that the tests were testing this function. After deleting the tests, there are no other uses of this function, and it can be deleted.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

In a previous PR, I removed all usages of a function except for one
located in a test. I have since realized that the tests were testing
this function. After deleting the tests, there are no other uses of this
function, and it can be deleted.
@dmjb dmjb requested a review from a team as a code owner July 22, 2024 15:28
@dmjb dmjb merged commit dff4c45 into main Jul 22, 2024
23 of 24 checks passed
@dmjb dmjb deleted the remove-redundant-tests branch July 22, 2024 15:35
@coveralls
Copy link

Coverage Status

coverage: 54.299%. remained the same
when pulling 8709064 on remove-redundant-tests
into c783987 on main.

dmjb added a commit that referenced this pull request Jul 22, 2024
Was meant to be part of #3951 but forgot to commit it :(
@dmjb dmjb mentioned this pull request Jul 22, 2024
10 tasks
dmjb added a commit that referenced this pull request Jul 22, 2024
Was meant to be part of #3951 but forgot to commit it :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants