Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove even more unused code #3952

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove even more unused code #3952

merged 1 commit into from
Jul 22, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 22, 2024

Was meant to be part of #3951 but forgot to commit it :(

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Was meant to be part of #3951 but forgot to commit it :(
@dmjb dmjb requested a review from a team as a code owner July 22, 2024 15:40
@coveralls
Copy link

Coverage Status

coverage: 54.307% (+0.008%) from 54.299%
when pulling 95f4560 on remove-redundant-tests-ii
into dff4c45 on main.

@dmjb dmjb merged commit 9d5b603 into main Jul 22, 2024
25 of 26 checks passed
@dmjb dmjb deleted the remove-redundant-tests-ii branch July 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants