Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sort inversion with pagination direction. #3968

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Align sort inversion with pagination direction. #3968

merged 1 commit into from
Jul 23, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 23, 2024

Summary

Fixes #3966

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Fixed unit tests.
Manually tested as follows

# first page
$ minder history list -s 3 -o json | jq '.data[] | "\(.evaluatedAt),\(.id)"' | tr -d \"
WARNING: Running against a test environment (127.0.0.1) and may not be stable
2024-07-23T14:18:42.386278Z,f7e32737-1995-4825-b22b-4a0746d92472
2024-07-23T14:18:42.367654Z,e49b6912-b52b-4016-ab8b-3210a9cb6947
2024-07-23T14:18:42.347620Z,b7bef1c7-8d09-4de7-bc87-fcc2d2ecfbb2

# second page
$ minder history list -s 3 -c KzE3MjE3NDQzMjIzNDc2MjA= -o json | jq '.data[] | "\(.evaluatedAt),\(.id)"' | tr -d \"
WARNING: Running against a test environment (127.0.0.1) and may not be stable
2024-07-23T14:18:42.333747Z,7c197aec-b6d5-4ee7-a470-df612abddcca
2024-07-23T14:18:42.321212Z,a1f70e3d-8eb2-41ba-be84-7a563fbf6483
2024-07-23T14:18:42.295792Z,a4bad9a3-12aa-4a08-8afd-6b6041a26629

# third page
$ minder history list -s 3 -c KzE3MjE3NDQzMjIyOTU3OTI= -o json | jq '.data[] | "\(.evaluatedAt),\(.id)"' | tr -d \"
WARNING: Running against a test environment (127.0.0.1) and may not be stable
2024-07-23T14:18:42.268525Z,b1a84aff-e920-43ff-a140-7d3f37145932
2024-07-23T14:18:41.979206Z,e5925659-e80e-4aab-8bfa-8c7e9ad1e634
2024-07-23T14:18:41.971077Z,c94ad42b-f5bd-421b-9b47-a85bb7ed9c6e

# second page backwards from third
$ minder history list -s 3 -c LTE3MjE3NDQzMjIyNjg1MjU= -o json | jq '.data[] | "\(.evaluatedAt),\(.id)"' | tr -d \"
WARNING: Running against a test environment (127.0.0.1) and may not be stable
2024-07-23T14:18:42.333747Z,7c197aec-b6d5-4ee7-a470-df612abddcca
2024-07-23T14:18:42.321212Z,a1f70e3d-8eb2-41ba-be84-7a563fbf6483
2024-07-23T14:18:42.295792Z,a4bad9a3-12aa-4a08-8afd-6b6041a26629

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt added the bug Something isn't working label Jul 23, 2024
@blkt blkt self-assigned this Jul 23, 2024
@blkt blkt requested a review from a team as a code owner July 23, 2024 16:41
@coveralls
Copy link

Coverage Status

coverage: 54.244% (+0.01%) from 54.231%
when pulling 467530f on issue-3966-bis
into 2b5bb5d on main.

@blkt blkt merged commit b854af1 into main Jul 23, 2024
24 checks passed
@blkt blkt deleted the issue-3966-bis branch July 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListEvaluationHistory RPC navigation to next page is faulty
3 participants