Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cases for selectors with multivalued selections #4022

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 27, 2024

Summary

I realized we don't have any test case for multiple selectors, let's fix
that

Fixes: #4016

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

I realized we don't have any test case for multiple selectors, let's fix
that

Fixes: mindersec#4016
@jhrozek jhrozek requested a review from a team as a code owner July 27, 2024 08:53
@coveralls
Copy link

Coverage Status

coverage: 54.51% (+0.01%) from 54.497%
when pulling 4a0a64d on jhrozek:selectors_test_multi
into 95535e5 on stacklok:main.

@JAORMX JAORMX merged commit c7a8e15 into mindersec:main Jul 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve selector unit tests with tests that exercise multiple selectors
5 participants