Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cases for selectors with multivalued selections #4022

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Extend test cases for selectors with multivalued selections #4022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 56 additions & 3 deletions internal/engine/selectors/selectors_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ func TestSelectSelectorEntity(t *testing.T) {
expectedSelectErr error
expectedStructuredErr *ErrStructure
selected bool
index int
}{
{
name: "No selectors",
Expand Down Expand Up @@ -518,6 +519,60 @@ func TestSelectSelectorEntity(t *testing.T) {
),
selected: false,
},
{
name: "Multiple selectors with the same entity type, the first one is true",
exprs: []models.ProfileSelector{
{
// true expression, should be evaluated and the entity should be kept for selection
Entity: minderv1.Entity_ENTITY_REPOSITORIES,
Selector: "repository.name == 'testorg/testrepo'",
},
{
// false expression, should cause the entity to be skipped
Entity: minderv1.Entity_ENTITY_REPOSITORIES,
Selector: "repository.is_fork == false",
},
},
selectorEntityBld: newTestRepoSelectorEntity(withIsFork(true)),
index: 1,
selected: false,
},
{
name: "Multiple selectors with different entity types",
exprs: []models.ProfileSelector{
{
// this one will be skipped as it's for a different entity
Entity: minderv1.Entity_ENTITY_PULL_REQUESTS,
Selector: "pull_request.name == 'testorg/testrepo/123'",
},
{
// false expression, should cause the entity to be skipped
Entity: minderv1.Entity_ENTITY_REPOSITORIES,
Selector: "repository.name != 'testorg/testrepo'",
},
},
selectorEntityBld: newTestRepoSelectorEntity(withIsFork(true)),
index: 1,
selected: false,
},
{
name: "Multiple selectors with generic entity type",
exprs: []models.ProfileSelector{
{
// true expression, will be evaluated, but evaluates to true
Entity: minderv1.Entity_ENTITY_REPOSITORIES,
Selector: "repository.name == 'testorg/testrepo'",
},
{
// false expression, will cause the entity to be skipped
Entity: minderv1.Entity_ENTITY_UNSPECIFIED,
Selector: "entity.name != 'testorg/testrepo'",
},
},
selectorEntityBld: newTestRepoSelectorEntity(withIsFork(true)),
index: 1,
selected: false,
},
}

for _, scenario := range scenarios {
Expand Down Expand Up @@ -560,9 +615,7 @@ func TestSelectSelectorEntity(t *testing.T) {
require.NoError(t, err)
require.Equal(t, scenario.selected, selected)
if !selected {
// TODO(jakub): Add tests with more selectors. If we have more than one selector, we should
// also match against an expected index
require.Equal(t, scenario.exprs[0].Selector, matchedSelector)
require.Equal(t, scenario.exprs[scenario.index].Selector, matchedSelector)
}
})
}
Expand Down