util: Use dedicated test package for unit tests #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a dedicated test package as opposed to including tests as part of the same `util` package. The idea with this pattern is that it allows us to test how a regular test implementation would actually use the functions. It also, deters us from testing specifics within the implementations which is not ideal.
jhrozek
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a dedicated test package as opposed to including tests as part
of the same
utilpackage.The idea with this pattern is that it allows us to test how a regular
test implementation would actually use the functions. It also, deters
us from testing specifics within the implementations which is not ideal.