Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Add test coverage for JSON/YAML utilities #773

Merged
merged 1 commit into from
Aug 29, 2023
Merged

util: Add test coverage for JSON/YAML utilities #773

merged 1 commit into from
Aug 29, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 28, 2023

No description provided.

jhrozek
jhrozek reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to rebase or make part of PR #772?

@JAORMX
Copy link
Contributor Author

JAORMX commented Aug 29, 2023

@jhrozek they didn't conflict 😄

@jhrozek
Copy link
Contributor

jhrozek commented Aug 29, 2023

@jhrozek they didn't conflict 😄

Ah, sorry, this one already uses package util_test. I must have looked at the import instead.

@JAORMX JAORMX merged commit 857e33a into main Aug 29, 2023
13 checks passed
@JAORMX JAORMX deleted the utils-test-jsonconvert branch August 29, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

@yrobla yrobla Awaiting requested review from yrobla

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAORMX @jhrozek