Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PvSTATEM 0.1.3 #215

Merged
merged 8 commits into from
Dec 23, 2024
Merged

PvSTATEM 0.1.3 #215

merged 8 commits into from
Dec 23, 2024

Conversation

Fersoil
Copy link
Collaborator

@Fersoil Fersoil commented Dec 23, 2024

Update of the main branch to include some error fixes

nizwant and others added 5 commits December 9, 2024 22:01
* Always return the absolute path for output path

* Store intermediates also in output_dir

* Fix path checking
* added proper dilution recognition in case the layout file as NA

* added tests and plate files, minor fixes

* removed unexecutable code fragment

---------

Co-authored-by: Fersoil <Fersoil>
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (02aaa80) to head (d84dd6e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   88.18%   88.20%   +0.02%     
==========================================
  Files          14       14              
  Lines        1718     1713       -5     
==========================================
- Hits         1515     1511       -4     
+ Misses        203      202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nizwant
Copy link
Collaborator

nizwant commented Dec 23, 2024

its all good, but there is missing NEWS.md

@Fersoil Fersoil marked this pull request as ready for review December 23, 2024 22:44
@Fersoil Fersoil merged commit d84dd6e into main Dec 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants