New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes WithProxy(#658) and leftover HttpClient(#675) issues #681

Closed

ebozduman wants to merge 1 commit into minio:master from ebozduman:proxy-ignored-issue

Collaborator

ebozduman commented Aug 23, 2022

Fixes 2 issues:
#658 : WithProxy is ignored
#675 : Inject Ioc-managed HttpClient for MinioClient via constructor


          Fixes WithProxy(minio#658) and leftover HttpClient(minio#675) issues

4c03d45

ebozduman mentioned this pull request

Inject Ioc-managed HttpClient for MinioClient via constructor #675

Closed

PurplestViper reviewed

View reviewed changes

Contributor

PurplestViper left a comment

I don't think this is a good solution, refer to PR #683.

harshavardhana closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet