Fixes random failures in bucket notification tests #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build functional test still fails on windows environment. |
This was referenced Sep 27, 2022
harshavardhana
approved these changes
Sep 27, 2022
ebozduman
force-pushed
the
missing-events-sleep-issue-691
branch
from
9f7f864
to
3ae94ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691
Sometimes the event is created so fast even before the subscriber is ready to capture the event, hence random failures. So, adding delay and sleep in the right places in the tests resolved the issue for almost always, although theoretically there is always a very low but still a chance to see this problem.