Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong MinIO Client Example example in README #694

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

lag945
Copy link
Contributor

@lag945 lag945 commented Sep 26, 2022

Compiler Error CS0246 The type or namespace name 'type/namespace' could not be found (are you missing a using directive or an assembly reference?)
We can declare bucket with 'var' or add 'using Minio.DataModel'.

we can declare bucket with var  or add using using Minio.DataModel.
@ebozduman
Copy link
Collaborator

@lag945

The build tests fail due to an issue fixed by PR #693 and it hasn't been merged yet.
As soon as PR#693 is merged, you just need to sync with master.

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lag945
Copy link
Contributor Author

lag945 commented Oct 3, 2022

@lag945

The build tests fail due to an issue fixed by PR #693 and it hasn't been merged yet. As soon as PR#693 is merged, you just need to sync with master.

@ebozduman Some checks were not successful, I don't understand how to "sync with master"? I need more detail instructions, please.

@ebozduman
Copy link
Collaborator

@lag945

I've spent some time to understand the issue and I could not find anything abnormal as the failing test does not seem to be doing anything special or different than before.
We may dig into more, if the same test continues to fail in a separate issue.
Rerunning the test did not hit any problem and your fix is now ready to be merged.

@ebozduman ebozduman merged commit 7d5a239 into minio:master Oct 4, 2022
@lag945 lag945 deleted the README-patch-20220926 branch October 4, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants