Adds progress for GetObjectAsync and PutObjectAsync methods #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Dec 11, 2022
ebozduman
requested changes
Jan 3, 2023
There was a problem hiding this comment.
Please add a new functional test for this new feature.
You can have one based on one of the PutObject_Test<N> tests in FunctionalTest.cs file.
Also run dotnet regitlint just before you create your commit to be able to include the lint changes in your commit. This will fix the Linux build failure.
ebozduman
requested changes
Jan 3, 2023
lukashev-di
force-pushed
the
add-progress
branch
from
ab478b5
to
bc8104f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #717