Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress into PutObject method #764

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Add progress into PutObject method #764

merged 6 commits into from
Jun 14, 2023

Conversation

lukashev-di
Copy link
Contributor

@lukashev-di lukashev-di commented Apr 13, 2023 •
edited
Loading

Fixes issue #717
Redo #723

@ebozduman
Copy link
Collaborator

@lukashev-di
I'll review and test it tomorrow.

@ebozduman
Copy link
Collaborator

@lukashev-di

Please rebase your branch and bring it up to speed.

ebozduman
ebozduman requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc file, API.md, accordingly and add some concise information/example on how to use the new progress feature.

ebozduman
ebozduman requested changes May 12, 2023
View reviewed changes
Docs/API.md Outdated Show resolved Hide resolved
Minio.Examples/Program.cs Show resolved Hide resolved
Minio.Functional.Tests/FunctionalTest.cs Show resolved Hide resolved
@ebozduman
Copy link
Collaborator

Most probably, this is the same build issue we see with PR #779
I am already looking into it. I just cannot reproduce it. Tried it on Windows 2019 Server and looking into it on Windows env.

@ebozduman
Copy link
Collaborator

@lukashev-di

Could you update the branch?
The build issue is fixed in the master branch.

@lukashev-di
Copy link
Contributor Author

I think the problem is the same

ebozduman
ebozduman approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 5e82e86 into minio:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukashev-di @ebozduman