Fixes

[martijn00]

Also fixes #772

@ebozduman

[martijn00]

@ebozduman can you merge?

[ebozduman]

@martijn00

I still see the same problem when CopyObject_Test8 functional test runs against framework net4.8.
Your fix looks complete, but still the same error:

{"name":"minio-dotnet : CopyObject_Test8","function":"Task<CopyObjectResult> CopyObjectAsync(CopyObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))","description":"Tests whether CopyObject with metadata replacement passes","args":{"bucketName":"minio-dotnet-example-ehym8w6609mh64g","objectName":"bf@ghe+#h+","destBucketName":"minio-dotnet-example-fwoxevgbqvmaec6","destObjectName":"minio-dotnet-example-hfko4gkvpn","data":"1KB","size":"1KB","copyconditions":"x-amz-metadata-directive:REPLACE"},"duration":1051,"status":"FAIL","alert":"Collection was modified; enumeration operation may not execute.","message":"System.InvalidOperationException: Collection was modified; enumeration operation may not execute.\n  at System.Collections.Generic.Dictionary`2+Enumerator[TKey,TValue].MoveNext () [0x00013] in <de882a77e7c14f8ba5d298093dde82b2>:0 \n  at Minio.CopyObjectArgs.Populate () [0x000fc] in <ae63953852d443a790f9788c050ef577>:0 \n  at Minio.CopyObjectArgs.Validate () [0x00093] in <ae63953852d443a790f9788c050ef577>:0 \n  at Minio.MinioClient.CopyObjectAsync (Minio.CopyObjectArgs args, System.Threading.CancellationToken cancellationToken) [0x0023f] in <ae63953852d443a790f9788c050ef577>:0 \n  at Minio.Functional.Tests.FunctionalTest.CopyObject_Test8 (Minio.MinioClient minio) [0x00575] in <87b15959cb13430c973a5940771c37d1>:0 "}

Unhandled Exception:
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.Collections.Generic.Dictionary`2+Enumerator[TKey,TValue].MoveNext () [0x00013] in <de882a77e7c14f8ba5d298093dde82b2>:0 
  at Minio.CopyObjectArgs.Populate () [0x000fc] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.CopyObjectArgs.Validate () [0x00093] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.MinioClient.CopyObjectAsync (Minio.CopyObjectArgs args, System.Threading.CancellationToken cancellationToken) [0x0023f] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.Functional.Tests.FunctionalTest.CopyObject_Test8 (Minio.MinioClient minio) [0x0077f] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.FunctionalTest.CopyObject_Test8 (Minio.MinioClient minio) [0x008a2] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.Program.Main (System.String[] args) [0x004db] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.Program.<Main> (System.String[] args) [0x0000c] in <87b15959cb13430c973a5940771c37d1>:0 
[ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.Collections.Generic.Dictionary`2+Enumerator[TKey,TValue].MoveNext () [0x00013] in <de882a77e7c14f8ba5d298093dde82b2>:0 
  at Minio.CopyObjectArgs.Populate () [0x000fc] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.CopyObjectArgs.Validate () [0x00093] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.MinioClient.CopyObjectAsync (Minio.CopyObjectArgs args, System.Threading.CancellationToken cancellationToken) [0x0023f] in <ae63953852d443a790f9788c050ef577>:0 
  at Minio.Functional.Tests.FunctionalTest.CopyObject_Test8 (Minio.MinioClient minio) [0x0077f] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.FunctionalTest.CopyObject_Test8 (Minio.MinioClient minio) [0x008a2] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.Program.Main (System.String[] args) [0x004db] in <87b15959cb13430c973a5940771c37d1>:0 
  at Minio.Functional.Tests.Program.<Main> (System.String[] args) [0x0000c] in <87b15959cb13430c973a5940771c37d1>:0 

[martijn00]

@ebozduman are you sure you pulled in the latest code from this branch? I explicetly test this on net4.8. I run CopyObject_Test8 again just now on 4.8 and it works fine now. Is there something I miss here?

[ebozduman]

let me check again

[ebozduman]

Yes. CopyObject_Test8 works.
I forgot to remove Minio 5.0.0 package in my csproj file.

[martijn00]

@ebozduman I've fixed the remark. Can you run CI again and merge?

[martijn00]

@ebozduman good find. Fixed now.

[ebozduman]

LGTM