Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #774

Merged
merged 13 commits into from
Apr 26, 2023
Merged

Fixes #774

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
72239bb
Fix
martijn00 Apr 24, 2023
d344017
Null checks
martijn00 Apr 24, 2023
81dcacc
Cleanup
martijn00 Apr 24, 2023
590bb6a
Is or is not null checks
martijn00 Apr 25, 2023
d56ff90
Update nuget
martijn00 Apr 25, 2023
74344e3
Fix concurency bug in older dotnet
martijn00 Apr 25, 2023
459d6fe
Fix buffer bug in older dotnet
martijn00 Apr 25, 2023
39397f9
More null checks
martijn00 Apr 25, 2023
a9dcae1
New name
martijn00 Apr 25, 2023
a6fd42f
Disable analyzer again
martijn00 Apr 25, 2023
451f972
Move more to extensions
martijn00 Apr 26, 2023
ea4f238
Invert checks
martijn00 Apr 26, 2023
8aceacd
Fix
martijn00 Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions Minio/DataModel/AccessCredentials.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,24 @@ public class AccessCredentials
public AccessCredentials(string accessKey, string secretKey,
string sessionToken, DateTime expiration)
{
if (string.IsNullOrEmpty(accessKey))
throw new ArgumentException($"'{nameof(accessKey)}' cannot be null or empty.", nameof(accessKey));
if (!string.IsNullOrEmpty(accessKey) || !string.IsNullOrEmpty(secretKey) || !string.IsNullOrEmpty(sessionToken))
{
AccessKey = accessKey;
SecretKey = secretKey;
SessionToken = sessionToken;
Expiration = expiration.Equals(default) ? null : Utils.To8601String(expiration);
}
else
{
if (string.IsNullOrEmpty(secretKey))
martijn00 marked this conversation as resolved.
Show resolved Hide resolved
throw new ArgumentException($"'{nameof(accessKey)}' cannot be null or empty.", nameof(accessKey));

if (string.IsNullOrEmpty(secretKey))
throw new ArgumentException($"'{nameof(secretKey)}' cannot be null or empty.", nameof(secretKey));
if (string.IsNullOrEmpty(secretKey))
throw new ArgumentException($"'{nameof(secretKey)}' cannot be null or empty.", nameof(secretKey));

if (string.IsNullOrEmpty(sessionToken))
throw new ArgumentException($"'{nameof(sessionToken)}' cannot be null or empty.", nameof(sessionToken));

AccessKey = accessKey;
SecretKey = secretKey;
SessionToken = sessionToken;
Expiration = expiration.Equals(default) ? null : Utils.To8601String(expiration);
if (string.IsNullOrEmpty(sessionToken))
throw new ArgumentException($"'{nameof(sessionToken)}' cannot be null or empty.", nameof(sessionToken));
}
}

public AccessCredentials()
Expand Down