Skip to content

Commit

Permalink
python 3.8 compatibility (#847)
Browse files Browse the repository at this point in the history
Fixed an issue where == should be used instead
of is for python 3.8 compatibility

* added 3.8 to the github workflow
  • Loading branch information
ktarplee authored and harshavardhana committed Jan 27, 2020
1 parent 98daf04 commit a146562
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pythonpackage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
max-parallel: 3
matrix:
python-version: [2.7, 3.6, 3.7]
python-version: [2.7, 3.6, 3.7, 3.8]
os: [ubuntu-latest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pythonpackage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
max-parallel: 3
matrix:
python-version: [2.7, 3.6, 3.7]
python-version: [2.7, 3.6, 3.7, 3.8]
os: [windows-latest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion minio/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def dump_http(method, url, request_headers, response, output_stream):
http_path))

for k, v in list(request_headers.items()):
if k is 'authorization':
if k == 'authorization':
# Redact signature header value from trace logs.
v = re.sub(r'Signature=([[0-9a-f]+)', 'Signature=*REDACTED*', v)
output_stream.write('{0}: {1}\n'.format(k.title(), v))
Expand Down

0 comments on commit a146562

Please sign in to comment.