Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.8 compatibility #847

Merged
merged 2 commits into from
Jan 27, 2020
Merged

python 3.8 compatibility #847

merged 2 commits into from
Jan 27, 2020

Conversation

ktarplee
Copy link
Contributor

Fixed an issue where == should be used instead of "is" for python 3.8

closes #846

@harshavardhana
Copy link
Member

Please fix the title typo @ktarplee compatibility

Praveenrajmani
Praveenrajmani previously approved these changes Jan 25, 2020
View reviewed changes
@ktarplee ktarplee changed the title python 3.8 compatability python 3.8 compatibility Jan 25, 2020
@harshavardhana
Copy link
Member

@ktarplee can you also update .github/workflows/pythonpackage-linux.yml to enable building with python 3.8 ?

Praveenrajmani
Praveenrajmani approved these changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit a146562 into minio:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8 syntax error
4 participants
@ktarplee @harshavardhana @serhiy-storchaka @Praveenrajmani