Remove BannableAddress generic (p2p) #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kokolemin
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
TheQuantumPhysicist
approved these changes
Aug 1, 2023
pavel-kokolemin
force-pushed
the
p2p_addresses_refactor
branch
from
dfafb1a
to
df473b8
Compare
muursh
approved these changes
Aug 1, 2023
TheQuantumPhysicist
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for discussion. I think it's time to remove two generic network addresses from p2p:
NetworkingService::AddressandNetworkingService::BannableAddress. Currently we useSocketAddr/IpAddrasAddress/BannableAddresseverywhere, and I don't see that changing anytime soon. Without these two generics, the code should be a bit cleaner. This PR removesBanableAddressto show this. If you agree, the next step will be to removeNetworkingService::Addressas well.