Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to non-generic p2p addresses #1144

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

pavel-kokolemin
Copy link
Contributor

@pavel-kokolemin pavel-kokolemin commented Aug 7, 2023

This is a continuation of the address refactoring PR (#1117).

I think the code should be a bit cleaner now, and allow for future improvements.

There is some overlap between PeerAddress and SocketAddress (they both currently represent a TCP socket address), but I think they should be kept separate. PeerAddress is something you can connect to to reach a peer, and SocketAddress is just a wrapper for OS socket address. Also, in the future, PeerAddress may contain other peer addresses, like Tor.

Copy link
Collaborator

@TheQuantumPhysicist TheQuantumPhysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. No big objections here.

@pavel-kokolemin pavel-kokolemin merged commit 620ebb5 into master Aug 8, 2023
23 checks passed
@pavel-kokolemin pavel-kokolemin deleted the p2p_remove_address_generic branch August 8, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants