Tests for new peer discovery when the tip is stale #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
ImplOfAnImpl
commented
Oct 24, 2023
Comment on lines
+55
to
+56
| async fn obtain_addresses(&self) -> Vec<SocketAddress> { | ||
| let dns_seed = match self.chain_config.chain_type() { |
There was a problem hiding this comment.
FYI: the logic in this function is not new; it was moved here from reload_dns_seed
ImplOfAnImpl
commented
Oct 24, 2023
p2p/src/peer_manager/mod.rs
Outdated
Comment on lines
1590
to
1593
| // This will be called at the end of "heartbeat" function. | ||
| fn on_heartbeat(&mut self); | ||
| // This will be called for both incoming and outgoing connections. | ||
| fn on_connection_acccepted(&mut self, address: SocketAddress); |
There was a problem hiding this comment.
FYI: I ended up not needing these functions in the final implementation of the tests; but I decided to keep them (and the corresponding PeerManagerNotification variants), because they may become useful in the future.
…NewLocalTip with NewChainstateTip, which is produced unconditionally.
TheQuantumPhysicist
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the tests work required some changes in production code as well:
last_tip_block_timetoPeerManager, which is now used to force a call toreload_dns_seed.Also, I had to add
PeerManagerEvent::NewLocalTip, so that the peer manager could learn about locally-produced tips too. This in turn required to addBlockSourcetoChainstateEvent::NewTip.reload_dns_seedwas moved toDefaultDnsSeed::obtain_addresses.