Make connection count limits modifiable in tests #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
ImplOfAnImpl
commented
Oct 24, 2023
Comment on lines
+88
to
+91
| pub preserved_inbound_count_address_group: PreservedInboundCountAddressGroup, | ||
| pub preserved_inbound_count_ping: PreservedInboundCountPing, | ||
| pub preserved_inbound_count_new_blocks: PreservedInboundCountNewBlocks, | ||
| pub preserved_inbound_count_new_transactions: PreservedInboundCountNewTransactions, |
There was a problem hiding this comment.
FYI: I ended up not needing to modify the inbound connection limits in the tests. But I decided to keep them here anyway, near their outbound counterparts, for completeness and because they may become useful in the future.
TheQuantumPhysicist
approved these changes
Oct 24, 2023
ImplOfAnImpl
force-pushed
the
make_connection_count_modifiable_in_tests
branch
from
1e1a3ca
to
f6e3ade
Compare
TheQuantumPhysicist
deleted the
make_connection_count_modifiable_in_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants related to the number of connections were placed into a struct
ConnectionCountLimitswhich is a part ofP2pConfig.This is a follow-up for the PR #1292. It's not strictly necessary, but it allows to make the tests in that PR less "heavy" by reducing the number of connections that those tests have to make.