-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reports: Fix select all OOIs #2909
Conversation
…nation into fix-select-all_oois
Checklist for QA:
What works:Looks good, we ended up finding a bug where no reports were shown when multiple objects were selected. That has been resolved. During the selection of objects you now also get the feedback how many objects you selected if you used the select all function. What doesn't work:Nothing found. Bug or feature?:Nothing found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minimal suggestions, should be ready merge soon
rocky/reports/report_types/aggregate_organisation_report/appendix.html
Outdated
Show resolved
Hide resolved
* main: (78 commits) Translations update from Hosted Weblate (#3048) Translations update from Hosted Weblate (#3018) Fix empty consumes of boefjes will trigger tasks in scheduler (#3017) Fixes text in secondary menu on scan profile detail page (#3035) chore: Resolves css-issues found by sonarcloud (#3034) Add raw AuthToken SQL migration (#3009) Translations update from Hosted Weblate (#3012) Rewrite xtdb-cli.py with "click" (#2957) Phase out the Repository model from the KATalogus (#2984) Fix merge conflicts in weblate (#3007) Translations update from Hosted Weblate (#2996) Reports: Fix select all OOIs (#2909) Adding IPv6 support to documentation for Docker setups (#2813) Translations update from Hosted Weblate (#2930) User documentation for reports (#2898) Fix task api status code response for malformed id in the scheduler (#2953) Add drill trace option in dnssec boefje (#2979) Updated packages (#2972) Update granian and remove workaround for fixed bug (#2980) Fix typing in boefjes/normalizers (#2933) ...
* main: (40 commits) Translations update from Hosted Weblate (#3091) feat: 📝 add API titles (#3055) Fixed 2 small mistakes in documentation (#3089) Documentation - developer and helper functionality documentation for xtdb-cli tool (#3023) fix: 🔧 update db normalize setting (#2777) Translations update from Hosted Weblate (#3048) Translations update from Hosted Weblate (#3018) Fix empty consumes of boefjes will trigger tasks in scheduler (#3017) Fixes text in secondary menu on scan profile detail page (#3035) chore: Resolves css-issues found by sonarcloud (#3034) Add raw AuthToken SQL migration (#3009) Translations update from Hosted Weblate (#3012) Rewrite xtdb-cli.py with "click" (#2957) Phase out the Repository model from the KATalogus (#2984) Fix merge conflicts in weblate (#3007) Translations update from Hosted Weblate (#2996) Reports: Fix select all OOIs (#2909) Adding IPv6 support to documentation for Docker setups (#2813) Translations update from Hosted Weblate (#2930) User documentation for reports (#2898) ...
Changes
ooi=all
this will trigger all other checkboxes to bedisabled
andchecked
ooi=all
resettingdisabled
andchecked
so user can do selections.Issue link
Closes #2911
Demo
Screen.Recording.2024-05-21.at.15.33.12.mov
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.