-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for CIPI dataset #599
Conversation
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 96.96% 97.02% +0.06%
==========================================
Files 58 60 +2
Lines 6990 7133 +143
==========================================
+ Hits 6778 6921 +143
Misses 212 212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PRamoneda, thanks for that! Just adding some questions/comments and minor fixes to do. Let me know if you have any questions!
mirdata/datasets/cipi.py
Outdated
except FileNotFoundError: | ||
raise FileNotFoundError( | ||
"MusicXML file {} for track {} not found. " | ||
"Did you run .download()?".format(self.musicxml_paths, self.track_id) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message is not well written! Because if a music xml file is not available, load_score will fail and specify which file is missing, but here, you will print the entire list... maybe you could just say something like "Missing MusicXML files. Did you run .download()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @PRamoneda sorry we missed that one. Can you take a look again?
It is ready! I am free. If you need help with something, let me know. And see you at ISMIR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PRamoneda! Added a few minor comments for the Track docstring but other than that looks good to me :) Please fix the mentioned mini-issues and IMO the loader will be ready to go!
Adding loader for CIPI (Can I play it?)
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist: